Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved shader for team colored textures #214

Closed
wants to merge 1 commit into from
Closed

improved shader for team colored textures #214

wants to merge 1 commit into from

Conversation

ptolstoi
Copy link

@ptolstoi ptolstoi commented Feb 7, 2015

resubmission: #202

@TheJJ TheJJ added improvement Enhancement of an existing component area: renderer Concerns our graphics renderer lang: c++ Done in C++ code labels Feb 7, 2015
@ptolstoi ptolstoi mentioned this pull request Feb 7, 2015
Closed
@TheJJ
Copy link
Member

TheJJ commented Feb 12, 2015

I think this is ready for merge, but we have to keep #204 in mind. Otherwise many users will totally get confused why the game looks wrong for them after this is merged.

@franciscod
Copy link
Contributor

what happens if you don't make media

openage_2015-02-13_03-25-42_00

@TheJJ
Copy link
Member

TheJJ commented Feb 13, 2015

that's why we need #204 to trigger a media reconversion 😉

@franciscod
Copy link
Contributor

franciscod commented Feb 13, 2015 via email

@franciscod
Copy link
Contributor

after make media:
openage_2015-02-13_14-06-46_00

seems nice! I like the alpha on the "ghost" player when building is not yet placed. 👍 🚢 🇮🇹

@mic-e
Copy link
Member

mic-e commented Jun 25, 2015

What's the status of this?

@TheJJ: Is this still valid with #287 in progress?

@TheJJ
Copy link
Member

TheJJ commented Jun 25, 2015

it'll be integrated in #287 but also requires #265 / #204 to be completed.

@TheJJ TheJJ closed this Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: renderer Concerns our graphics renderer improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptolstoi @TheJJ @franciscod @mic-e